Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/internal 31 update sidebar component 763 #794

Merged
merged 14 commits into from
Jan 16, 2024
Merged

Task/internal 31 update sidebar component 763 #794

merged 14 commits into from
Jan 16, 2024

Conversation

bluemoonecho
Copy link
Contributor

@bluemoonecho bluemoonecho commented Jul 24, 2023 •
edited
Loading

Takes care of issue #763

Zeplin
Ticker

Changes

  • Uses the invisible button variant
    • Buttons fill the container width
    • Have a padding of 0.5rem to the sides.
  • Have a spacing of 0.75rem between buttons
  • A divider of 2px can be used at the bottom if showing an account avatar or CTA.
  • There is a dropdown shadow (only on mobile)
  • When there are many buttons the sidebar scrolls
  • The bottom section, logo and close icon remain sticky when scrolling.

📸 Looks like

📱 🖥️
Screenshot 2023-07-24 at 16 51 46 Screenshot 2023-07-24 at 16 40 24

planktonic
planktonic reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@planktonic planktonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sidebar looks great! ✨

The buttons look good too, but they’re different to the zeplin designs — is there some inconsistency there, do we need to update the designs?

A final note: can you check that the zeplin components are linked to the stories please, so we can more easily QA these against designs? 🙏

scss/bitstyles/ui/sidebar.stories.mdx Outdated Show resolved Hide resolved
scss/bitstyles/ui/sidebar.stories.mdx Outdated Show resolved Hide resolved
planktonic
planktonic approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@planktonic planktonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, so that storybook works properly again :) Then this is good to go! ⚡️

scss/bitstyles/ui/sidebar.stories.mdx Outdated Show resolved Hide resolved
@planktonic
Copy link
Member

@bluemoonecho ah, tests are failing because the fixtures need updating — give me a shout if I can help get that sorted out

@bluemoonecho bluemoonecho force-pushed the task/internal-31-update-sidebar-component-763 branch from d2d32b2 to 2c7c166 Compare January 16, 2024 14:29
@bluemoonecho bluemoonecho merged commit 784eb73 into main Jan 16, 2024
1 check passed
@bluemoonecho bluemoonecho deleted the task/internal-31-update-sidebar-component-763 branch January 16, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planktonic planktonic planktonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluemoonecho @planktonic